Normalize file path when generating package name#3
Merged
wesleyegberto merged 1 commit intoJul 9, 2021
Merged
Conversation
Convert Windows path separators \ to /
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an issue on Windows with the package name generated for test classes.
Steps to recreate
C:\chris\wc\sample-multi-module\library\src\main\java\com\example\multimodule\service\MyService.javapackage mple-multi-module\library\src\test\java\com\example\multimodule\service;Root Cause
In a nutshell, the code uses
uri.fsPathfor the path and assumes the path separator is/, however on Windows the path separator (frustratingly) is\Proposed Fix
This proposed fix normalizes the path by converting all
\to/in the file path once, and for consistency uses that normalized path for all package name generation functionality.I tested generating a test class on both Windows and Linux, and this fix generated the correct package name in both!